Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types.tsx #11281

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update types.tsx #11281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0356b1
Update types.tsx
nikmantulenko Mar 15, 2023
3b84583
Merge branch 'main' into main
nikmantulenko Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/native-stack/src/types.tsx
View file
Open in desktop
Expand Up @@ -4,7 +4,7 @@
NavigationHelpers,
NavigationProp,
ParamListBase,
Route,

Check failure on line 7 in packages/native-stack/src/types.tsx

View workflow job for this annotation

GitHub Actions / autofix 

'Route' is defined but never used

Check failure on line 7 in packages/native-stack/src/types.tsx

View workflow job for this annotation

GitHub Actions / lint 

'Route' is defined but never used
RouteProp,
StackActionHelpers,
StackNavigationState,
Expand Down Expand Up @@ -64,7 +64,10 @@
// We want it to be an empty object because navigator does not have any additional props
export type NativeStackNavigationConfig = {};

export type NativeStackHeaderProps = {
export type NativeStackHeaderProps<
ParamList extends ParamListBase,
RouteName extends keyof ParamList = string,

Check failure on line 69 in packages/native-stack/src/types.tsx

View workflow job for this annotation

GitHub Actions / lint 

Delete `,`
> = {
/**
* Options for the back button.
*/
Expand All @@ -81,11 +84,11 @@
/**
* Route object for the current screen.
*/
route: Route<string>;
route: RouteProp<ParamList, RouteName>;
/**
* Navigation prop for the header.
*/
navigation: NativeStackNavigationProp<ParamListBase>;
navigation: NativeStackNavigationProp<ParamList, RouteName>;
};

export type HeaderButtonProps = {
Expand Down