fix: propagate textDidChangeNotification and editingChanged events further
#305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillzyusko
added a commit
to kirillzyusko/react-native-keyboard-controller
that referenced
this pull request
Jan 21, 2024
…nput from `react-native-text-input-mask` on iOS (#341) ## 📜 Description Fixed a problem when `onTextChange` is not fired on iOS if `TextInput` from `react-native-text-input-mask`. ## 💡 Motivation and Context The issue and solution is described [here](https://github.com/RedMadRobot/input-mask-ios?tab=readme-ov-file#uitextfieldtextdidchange-notification-and-target-action-editingchanged-event). However, if I add delegate with `onEditingChanged` method, then I can not assign my listener to this callback (the delegate can not be casted to my own type and I can not import existing class from another module because RNKC is not depending on another module). And adding an optional dependency to Podfile makes installation process harder and I don't see explicit benefits of making the approach more complex. For now I'll go with this solution (also I opened a PR to `react-native-text-input-mask`, see react-native-text-input-mask/react-native-text-input-mask#305). Maybe later I'll revisit and make it more sophisticated, but for now we have a working solution and I'm pretty happy with that. Closes #330 ## 📢 Changelog ### Docs - add a reference to the known problem (it should be fixable by applying a patch); ### E2E - added new test to check that `react-native-text-input-mask` integration works; ### JS - changed icon for `react-native-text-input-mask` example; - specified `black` color for TextInput in `react-native-text-input-mask` example; - patched `react-native-text-input-mask` library; ## 🤔 How Has This Been Tested? Tested on iPhone 15 Pro 17.2 ## 📸 Screenshots (if appropriate): |Before|After| |------|------| ||| ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
|
Eventually I went into a different direction and I'm adding own delegate to focused inputs (and consume I'm closing this PR as it's not needed anymore, I believe 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if I add another listener for
editingChangedevent -> I'll not get any updates.It happens because of problem described here (a particular issue with discussion was in RedMadRobot/input-mask-ios#12 but it's in Russian language).
In general author of
input-mask-iossuggest to add a custom delegate withonEditingChangedcallback. However for 3rd party libraries (such as react-native-keyboard-controller it could be a problematic approach, because I need to set a callback totextFielddelegate - but for that I need to know the interface/protocol of this delegate, and I can not import this protocol fromreact-native-text-input-mask- in order to do this I need to make a dependency onreact-native-text-input-maskin Podfile, but it should be optional dependency and I feel like it makes an approach very complicated without explicit benefits).So I went with an approach where we directly re-send events 👀
Feel free to suggest other alternatives if you have them!
Also for reference I'm attaching an original PR with fix from
react-native-keyboard-controller: kirillzyusko/react-native-keyboard-controller#341