-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Fix "react_native_menu-Swift.h" cannot be found #807
base: master
Are you sure you want to change the base?
Conversation
Hey, @alantoa, the issue to which you are referring was happening before my PR the issue happens in NEW ARCH, while my fix fixes it for OLD ARCH. You can check the version to which people are referring is 1.0.2 and what they are using And that it happened more than 2 days before my PR was merged and released Are you sure that you are using OLD ARCH? |
is it possible for expo to auto upgrade this package when doing npx expo upgrade --fix? |
Yeah, that's kind of weird. Ideally, it should work for both versions, but only v1.0.2 works for me. Let me take another look then. |
Wow, thanks, downgrade to v1.0.2 + Old Arch works now! Thanks! :) "expo": "~51.0.8", |
Any updates on this? |
This needs to be merged in as it's still a problem and it's causing build errors on iOS. Please merge this in asap @Naturalclar |
@sohail-wayland, hey, this depends on @Naturalclar. I'm not quite sure which one is actually correct. |
+1 this is actively broken |
Overview
I noticed that many users have been facing this build error on iOS since the last version was released. It is due to a change made in this PR.
I assume that this import is correct, but I'm not sure why @svbutko still encountered this issue. Could you please check if the build error is related to this? Thank you!
Test Plan
After changing it to
#import <react_native_menu/react_native_menu-Swift.h>
, the error disappeared.