Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix "react_native_menu-Swift.h" cannot be found #807

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alantoa
Copy link
Contributor

@alantoa alantoa commented May 11, 2024

Overview

CleanShot 2024-05-12 at 03 32 21@2x
I noticed that many users have been facing this build error on iOS since the last version was released. It is due to a change made in this PR.

I assume that this import is correct, but I'm not sure why @svbutko still encountered this issue. Could you please check if the build error is related to this? Thank you!

Test Plan

After changing it to #import <react_native_menu/react_native_menu-Swift.h>, the error disappeared.CleanShot 2024-05-12 at 03 38 08@2x

@alantoa alantoa requested a review from Naturalclar as a code owner May 11, 2024 19:38
@svbutko
Copy link
Contributor

svbutko commented May 11, 2024

Hey, @alantoa, the issue to which you are referring was happening before my PR the issue happens in NEW ARCH, while my fix fixes it for OLD ARCH.

You can check the version to which people are referring is 1.0.2 and what they are using

And that it happened more than 2 days before my PR was merged and released

Are you sure that you are using OLD ARCH?

@Darren120
Copy link

Hey, @alantoa, the issue to which you are referring was happening before my PR the issue happens in NEW ARCH, while my fix fixes it for OLD ARCH.

You can check the version to which people are referring is 1.0.2 and what they are using

And that it happened more than 2 days before my PR was merged and released

Are you sure that you are using OLD ARCH?

is it possible for expo to auto upgrade this package when doing npx expo upgrade --fix?

@alantoa
Copy link
Contributor Author

alantoa commented May 12, 2024

Yeah, that's kind of weird. Ideally, it should work for both versions, but only v1.0.2 works for me. Let me take another look then.

@Albert-Gao
Copy link

Yeah, that's kind of weird. Ideally, it should work for both versions, but only v1.0.2 works for me. Let me take another look then.

Wow, thanks, downgrade to v1.0.2 + Old Arch works now! Thanks! :)

"expo": "~51.0.8",
"react-native": "0.74.1",
"@react-native-menu/menu": "1.0.2",

@tompetk
Copy link

tompetk commented May 25, 2024

Any updates on this?

@sohail-wayland
Copy link

sohail-wayland commented May 28, 2024

This needs to be merged in as it's still a problem and it's causing build errors on iOS. Please merge this in asap @Naturalclar

@alantoa
Copy link
Contributor Author

alantoa commented May 28, 2024

@sohail-wayland, hey, this depends on @Naturalclar. I'm not quite sure which one is actually correct.
but for now, you can simply install v1.0.2, as its code is the same as this PR.

@awilson9
Copy link

+1 this is actively broken

@SohelIslamImran
Copy link

image Having same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants