Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): update Gradle tools version #1260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(android): update Gradle tools version #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions android/build.gradle
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:3.5.3'
classpath 'com.android.tools.build:gradle:8.2.2'
}
}
}
Expand All @@ -22,12 +22,12 @@ android {
if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
namespace "com.reactnativegooglesignin"
}
compileSdkVersion safeExtGet('compileSdkVersion', 30)
buildToolsVersion safeExtGet('buildToolsVersion', '30.0.2')

compileSdkVersion safeExtGet('compileSdkVersion', 34)
buildToolsVersion safeExtGet('buildToolsVersion', '34.0.0')
defaultConfig {
minSdkVersion safeExtGet('minSdkVersion', 21)
targetSdkVersion safeExtGet('targetSdkVersion', 30)
targetSdkVersion safeExtGet('targetSdkVersion', 34)
versionCode 1
versionName "1.0"
}
Expand Down
5 changes: 1 addition & 4 deletions android/src/main/AndroidManifest.xml
View file
Open in desktop
@@ -1,4 +1 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.reactnativegooglesignin">

</manifest>
<manifest package="com.reactnativegooglesignin"/>