Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add VisionOS platform, initial data seed #1131

Merged
merged 2 commits into from
Feb 22, 2024
Merged

add VisionOS platform, initial data seed #1131

merged 2 commits into from
Feb 22, 2024

Conversation

Simek
Copy link
Member

@Simek Simek commented Feb 22, 2024

πŸ“ Why & how

React Native VisionOS out-of-tree platform is getting some traction and userbase already, so it would be nice to include it in the directory.

The initial data seed has been based on the repos I have seen on X and verified by checking their repo code.

@okwasniewski Please let me know if I have missed some! Also happy to know if there is an indicator that library support VisionOS that we can check automatically when analyzing packages data.

βœ… Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json
  • Documented in this PR how to use the feature or replicate the bug.
  • Documented in this PR how you fixed or created the feature.

Preview

Important

Screen do not include all libraries marked as supported (only debug repos)!

screencapture-localhost-3000-2024-02-22-18_53_11

@Simek Simek added the deploy label Feb 22, 2024
@Simek
Copy link
Member Author

Simek commented Feb 22, 2024

Copy link
Contributor

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Regarding discovery, libraries need to add visionos to Podspec so I would use that.

@thiagobrez
Copy link

@Simek react-native-async-storage also already released support: react-native-async-storage/async-storage#1063

And react-native-keychain should be close (approved, not yet released)

@Simek
Copy link
Member Author

Simek commented Feb 22, 2024

Thanks for the references @thiagobrez! Just added Async Storage support.

And oblador/react-native-keychain#622 should be close (approved, not yet released)

Let's follow up with a separate PR updating the status when it will get released.

@Simek Simek merged commit bff3436 into main Feb 22, 2024
3 checks passed
@Simek Simek deleted the add-visionos-platform branch February 22, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants