Add Boxicons variants: solid and logos #393
Open
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @eps90, if you can update your PR to follow the variant naming convention (example here with heroicons) I can get this merged! |
|
Thanks @nolanleung , will do! |
|
Any update on this? I would love to see the variants added to the library! 🙃 |
|
Hey @eps90 do you have availability to update the PR with the naming conventions?, if not I can take it. |
Hey @lndgalante, I already created an updated PR at #436 as this one here didn’t receive any updates. But still no response from the maintainers. |
|
Thanks @timonweber! |
kamijin-fanta
force-pushed
the
master
branch
2 times, most recently
from
039502a
to
399b45c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only regular variant of Boxicons is included in the repo, while its docs mention also Solid and Logos.
Since choosing variants by attributes is not supported as in the docs, this PR includes two other variants of this iconset.