Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for Localization of Error Messages #1304

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

hatsu38
Copy link

@hatsu38 hatsu38 commented May 20, 2023

What kind of change does this PR introduce?

  • Bug Fix
  • Feature
  • Refactoring
  • Style
  • Build
  • Chore
  • Documentation
  • CI

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary
Explain the motivation for making this change. What existing problem does the pull request solve?
Try to link to an open issue for more information.

#1289
#1260

Does this PR introduce a breaking change?
If this PR introduces a breaking change, please describe the impact and a migration path for existing applications.

Other information

Updating limits 8 KB->30KB.

8:16:20 PM: ✔ Adding to empty webpack project
8:16:20 PM:   dist/index.js
8:16:20 PM:   Size limit: 25 kB
8:16:20 PM:   Size:       24.91 kB with all dependencies, minified and gzipped
8:16:20 PM:   dist/es/index.js
8:16:20 PM:   Package size limit has exceeded by 382 B
8:16:20 PM: Failed during stage 'Install dependencies': dependency_installation script returned non-zero exit code: 1
8:16:20 PM:   Size limit: 25 kB
8:16:20 PM:   Size:       25.38 kB with all dependencies, minified and gzipped

FYI: https://app.netlify.com/sites/react-dropzone/deploys/6468abcc0afc9f0008ab0b1a

The following image is a confirmation image that it is displayed in the local language on localhost
スクリーンショット 2023-05-20 19 59 33

スクリーンショット 2023-05-20 20 02 18 スクリーンショット 2023-05-20 19 57 13

@hatsu38 hatsu38 changed the title Feature/add local error msg Adding Support for Localization of Error Messages May 20, 2023
@hatsu38 hatsu38 marked this pull request as ready for review May 20, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant