fix: Improve accessibility of input #1219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using "display: none" often prevents screen readers from seeing the content. What we really want is to visually hide the standard input. We also add a placeholder to be announced by screen readers which can optionally be rendered also.
|
What's the blocker on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using "display: none" often prevents screen readers from seeing the content. What we really want is to visually hide
the standard input. We also add a placeholder to be announced by screen readers which can optionally be rendered also.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Using "display: none" often prevents screen readers from seeing the content. What we really want is to visually hide
the standard input. We also add a placeholder to be announced by screen readers which can optionally be rendered also.
Does this PR introduce a breaking change?
Non-breaking change.
Other information