Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typings for monitor.getItem() #3484

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typings for monitor.getItem() #3484

wants to merge 2 commits into from

Conversation

akphi
Copy link

@akphi akphi commented Aug 9, 2022 •
edited

I have noticed that this method should be annotated as potentially returning null. What do you think @darthtrevino ?

@akphi
Copy link
Author

akphi commented Oct 3, 2022 •
edited

@darthtrevino sorry to bother, is there anything else I could do here to get this fix in?

@jtbandes
Copy link

Would be a great fix! This seems like a no-brainer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darthtrevino darthtrevino Awaiting requested review from darthtrevino darthtrevino is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akphi @jtbandes