-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update disable prev and next state on month and year change #2169
base: master
Are you sure you want to change the base?
Update disable prev and next state on month and year change #2169
Conversation
Thanks! Could you add some tests for this behavior? |
Two tests added |
546a545
to
d958c42
Compare
@ljharb anything missing? |
@ljharb, Is there any reason that it is taking almost one week to re-review this pr? |
@guidosreis yes, it's the holidays, i have a family, and i'm doing this for free. it might take a month, and that's ok. |
d958c42
to
7335f71
Compare
7335f71
to
ee04403
Compare
You're right, of course you have other priorities. |
Happy birthday to this pull request!! |
Behavior with the current implementation (Next arrow don't get enabled when changing to a previous month on the select):
Behavior with the fix: