Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 在picker组件中使用calendar组件时, calendar的selectValue属性无效问题 #615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Crayonn
Copy link

@Crayonn Crayonn commented Aug 14, 2019

问题描述:
picker组件的会拦截calendar的selectValue, 这个是有什么考虑吗?

const calendar = (
            <Calendar selectValue={moment()}/>  // 此时calendar组件中的selectValue 为 undefined
        )
        return (
            <Picker calendar={calendar}>
                {this.renderChild}
            </Picker>
        );

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #615 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files          10       10           
  Lines         716      716           
  Branches      214      214           
=======================================
  Hits          650      650           
  Misses         57       57           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d486704...ced1dfe. Read the comment docs.

@Crayonn Crayonn changed the title 修复calendar组件在picker组件中使用时,selectValue无效问题 fix: 在picker组件中使用calendar组件时, calendar的selectValue属性无效问题 Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant