RangeCalendar format propType to work with array #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `format` prop accepts both `string` and `string[]`. Update the `format` prop type to match the underlying `CalendarPart` component.
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 10 10
Lines 716 716
Branches 214 214
=======================================
Hits 650 650
Misses 57 57
Partials 9 9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
formatprop accepts bothstringandstring[].Update the
formatprop type to match the underlyingCalendarPartcomponent.Without this change, passing an array of formats to the
RangeCalendarcomponent works but results in a warning.