Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: let pre-commit-autoupdate create prs in draft mode #965

Merged
merged 1 commit into from Apr 24, 2024

Conversation

afuetterer
Copy link
Member

@afuetterer afuetterer commented Apr 16, 2024

Description

At the moment the pre-commit PRs do not trigger checks, which is not ideal, because the updates could lead the failing tests.

This PR updates the pre-commit-autoupdate job to create PR in draft mode. Once a draft PR is set to "ready for review" by a RMDO contributor, the additional CI checks will run on that PR.

Motivation and Context

See above.

How has this been tested?

In my fork of the project.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @afuetterer, makes sense!

@MyPyDavid MyPyDavid merged commit 6180564 into rdmorganiser:dependency-updates Apr 24, 2024
17 checks passed
@afuetterer afuetterer deleted the pr-draft branch April 24, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants