Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable markdown renderer for more than just help texts #917

Closed
wants to merge 2 commits into from
Closed

Conversation

triole
Copy link
Member

@triole triole commented Feb 22, 2024

The goal of this pull request is to have the markdown renderer available for question texts as it is right now for help texts.

Description

  • enable markdown rendering for the following elements in questions answer section
    • page titles
    • question set titles
    • question texts

Related issue: #441

Motivation and Context

The STAMP project needs it because they love to style their text snippets.

Remarks

There are titles which are bold by default. I did not want to have those and removed them using css.

.form_label {
    font-weight: unset;
}

My fix..

How has this been tested?

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@triole triole marked this pull request as draft February 22, 2024 13:07
@triole triole changed the title Enable markdown rendering for question texts in answer section Enable markdown renderer for more than just help texts Feb 22, 2024
@jochenklar
Copy link
Member

I think this issue is related: #441

@triole
Copy link
Member Author

triole commented Feb 22, 2024

yes, thanks. i added it in the description

@coveralls
Copy link

coveralls commented Feb 22, 2024

Coverage Status

coverage: 91.591%. remained the same
when pulling 034d6e0 on markdown
into c945d7d on main.

@MyPyDavid
Copy link
Member

does this also have to do with adding (markdown) links to the text of options for example?

@triole
Copy link
Member Author

triole commented Apr 25, 2024

Currently not. This is something that will probably be added in the future. Every change should mentioned above in the description. What is not in the description is not in the code.

@MyPyDavid
Copy link
Member

I could add some parts for that if it will make this PR ready for the next release.
Is there still much to be done for this PR? It's not clear to me.

When I would add this for the option text, I could simply use your changes and apply them to the options right?

@jochenklar
Copy link
Member

jochenklar commented May 14, 2024

The markdown support for option text and help are implemeted in the interview branch. Since I want to implement markdown in catalog/section/page/questionset titles and question texts there as well I can add the corresponding code in the non angular parts already here.

@jochenklar jochenklar closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants