Add SITE_ID, DEBUG_TOOLBAR, ALLOWED_HOSTS, and BASE_URL to settings

[jochenklar]

No description provided.

[MyPyDavid]

Do you want to split the settings in here? Or is the dependency in here for the rdmo-app?
Edit: I see now, there are no dependencies in the rdmo-app

[jochenklar]

The nice thing about django-split-settings is that you don't need to include AUTHENTICATION_BACKENDS, MIDDLEWARES, etc. in local.py anymore.

[jochenklar]

@MyPyDavid can I merge?

[MyPyDavid]

yes, looks good, thanks!
Think that default value for BASE_URL will also prevent some issues in deployments.

[afuetterer]

I can fix the merge conflict, if you want.

[jochenklar]

@afuetterer sure, go ahead.

[afuetterer]

Damn it, I tried the GitHub web UI to resolve the merge conflict. I did not realize that it would then merge the branch. A rebase would have sufficed.
Should I force push later and fix this?

[MyPyDavid]

Do you mean to force the branch back to b4d0452 and then rebase?

[jochenklar]

yes, I would checkout the old commit, rebase, force push.

[afuetterer]

Done, sorry for the confusion.

[jochenklar]

Urgs, now it does not work with the old rdmo-app anymore ... I think we need to remove BASE_URL again, and set it in the new rdmo-app.

[jochenklar]

Alternatively we can set it to BASE_URL = ''. What do you think @MyPyDavid ?