Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDMO 2.0.0 #649

Merged
merged 602 commits into from
Sep 21, 2023
Merged

RDMO 2.0.0 #649

merged 602 commits into from
Sep 21, 2023

Conversation

jochenklar
Copy link
Member

No description provided.

jochenklar and others added 30 commits June 23, 2023 13:00
in template and rules.py
OptionSerializer and OptionSetSerializer
@afuetterer

This comment was marked as resolved.

pyproject.toml Outdated Show resolved Hide resolved
@afuetterer
Copy link
Member

This is one big PR. :)

@afuetterer
Copy link
Member

afuetterer commented Sep 20, 2023

Yes, that would be great. Since we use react now, we could also think about adding tests for the front-end. I have no clue about the ecosystem there. This is something for the next year.

I think you can test the frontend code with javascript unit tests, like jest.

And the test the bundled frontend in combination with a django-liveserver you can use selenium, playwright or cypress nowadays.

I wrote a couple of functional tests with selenium for another project. But I think playwright might be taking over.

Refs:

}))
break

case 'attributes':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a user flow: conditions > new > create new attribute > create > User can not create a new attribute for an "uncreated" condition. The user is stuck and can only go back.

This attribute will be added to the condition undefined.

Should the "create new attribute" button be blocked in this case or is it bug somehow? To prevent a user getting stuck there..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should now be fixed, the button is disabled as long as the new element is not saved.

@afuetterer
Copy link
Member

If the development docs move to the docs-en repository, the docs directory in this repo can be removed, right?
The links to the dev docs in https://github.com/rdmorganiser/rdmo/blob/dev-2.0.0/CONTRIBUTING.md shoulkd be updated as well.

@jochenklar jochenklar marked this pull request as ready for review September 21, 2023 15:10
@jochenklar jochenklar merged commit 3252c54 into master Sep 21, 2023
19 checks passed
@jochenklar jochenklar deleted the dev-2.0.0 branch September 21, 2023 15:52
CalamityC pushed a commit to CalamityC/rdmo that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants