-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add counters to project overview #606
Merged
jochenklar
merged 22 commits into
dev-1.10.0
from
feature/355-add-counters-to-project-overview
Apr 27, 2023
Merged
add counters to project overview #606
jochenklar
merged 22 commits into
dev-1.10.0
from
feature/355-add-counters-to-project-overview
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyPyDavid
commented
Apr 11, 2023
jochenklar
requested changes
Apr 13, 2023
…and move querystring setter to utils
jochenklar
approved these changes
Apr 27, 2023
CalamityC
pushed a commit
to CalamityC/rdmo
that referenced
this pull request
Nov 23, 2023
…-counters-to-project-overview add counters to project overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains one of the features mentioned in #355.
Counters (numbers) were added to the templates
rdmo/projects/templates/projects/projects.html
rdmo/projects/templates/projects/projects_pagination.html
rdmo/projects/templates/projects/site_projects.html
"Search" renamed to "Filter Projects
a counter is placed under filter input block in small text:
number_of_projects
for the user was added to theget_context_data
of theFilterView
a counter at the footer of the pagination, which shows the number of projects in the current pagea bugfix for the pagination in combination with filter was added in the context data of
rdmo/projects/views/project.py
:rdmo/projects/utils.py
added tests in
rdmo/projects/tests/test_utils.py
a bugfix for Bug in display of "My Projects", single project(s) disappears from list or shown double (front-end, view queryset) #578 was added in the
rdmo/projects/views/project.py