Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor object permissions in a multisite #565

Merged
merged 246 commits into from
Jun 29, 2023

Conversation

MyPyDavid
Copy link
Member

@MyPyDavid MyPyDavid commented Jan 18, 2023

Implementation for #490 with object level permissions and an "editor" per site.
The additions:

  • editor and reviewer to user Role , m2m with Site
  • editors field to all element models, m2m with Site
  • object permission rules for all elements, checks are based on the editors and user Role
  • test fixtures for foo.com and bar.com and users e.g. foo-editor, bar-editor, ...
  • the HasObjectPermission to the Viewsets
    • included tests for this
  • the read_only field to the Serializers
    • via the ReadOnlyObjectPermissionsSerializerMixin class in rdmo/core/serializers.py
  • read_only displayed in front-end templates.

Status, changelog

  • change target base branch into dev-1.10.0
  • change target base branch into dev-2.0.0
  • merged dev-2.0.0+refactor_elements into feature/490-editor-permissions-multisite, thank you @jochenklar ;)
  • fix the todos from after the merge
  • add the editors selection and read_only functions to React front-end
  • fix remaining tests, add fixture
  • other todos..

@MyPyDavid MyPyDavid changed the title Editor object permissions multisite Editor object permissions in a multisite Jan 20, 2023
@coveralls
Copy link

coveralls commented Jan 21, 2023

Coverage Status

Coverage: 90.692% (+0.2%) from 90.469% when pulling 56cce83 on feature/490-editor-permissions-multisite into 813df5e on dev-1.10.0.

@MyPyDavid MyPyDavid changed the title Editor object permissions in a multisite Refactor element, React and Editor object permissions in a multisite Jun 29, 2023
@MyPyDavid MyPyDavid changed the title Refactor element, React and Editor object permissions in a multisite Refactor elements, React and Editor object permissions in a multisite Jun 29, 2023
@jochenklar jochenklar marked this pull request as ready for review June 29, 2023 09:04
@jochenklar jochenklar merged commit 3c53da5 into dev-2.0.0 Jun 29, 2023
0 of 12 checks passed
@MyPyDavid MyPyDavid changed the title Refactor elements, React and Editor object permissions in a multisite Editor object permissions in a multisite Jun 29, 2023
@jochenklar jochenklar deleted the feature/490-editor-permissions-multisite branch August 19, 2023 07:38
CalamityC pushed a commit to CalamityC/rdmo that referenced this pull request Nov 23, 2023
…ite'

Fixes base branch 490-editor-permissions-multisite

See pull request rdmorganiser#565
CalamityC pushed a commit to CalamityC/rdmo that referenced this pull request Nov 23, 2023
…tor-permissions-multisite

Refactor elements, React and Editor object permissions in a multisite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants