chore: update signature for storeElement to use default parameters

Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
rdmorganiser · May 16, 2024 · 8757d2c · 8757d2c
1 parent c56f53b
commit 8757d2c
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/rdmo/management/assets/js/actions/elementActions.js b/rdmo/management/assets/js/actions/elementActions.js
@@ -342,7 +342,7 @@ export function fetchElementError(error) {
 
 // store element
 
-export function storeElement(elementType, element, elementAction, back) {
+export function storeElement(elementType, element, elementAction = null, back = false) {
   return function(dispatch, getState) {
 
     dispatch(storeElementInit(element, elementAction))
@@ -653,9 +653,9 @@ export function dropElement(dragElement, dropElement, mode) {
       const element = {...getState().elements.element}
       const { dragParent, dropParent } = moveElement(element, dragElement, dropElement, mode)
 
-    dispatch(storeElement(elementTypes[dragParent.model], dragParent, null, false))
+    dispatch(storeElement(elementTypes[dragParent.model], dragParent))
     if (!isNil(dropParent)) {
-      dispatch(storeElement(elementTypes[dropParent.model], dropParent, null, false))
+      dispatch(storeElement(elementTypes[dropParent.model], dropParent))
       }
     }
   }

diff --git a/rdmo/management/assets/js/components/element/Catalog.js b/rdmo/management/assets/js/components/element/Catalog.js
@@ -24,10 +24,10 @@ const Catalog = ({ config, catalog, elementActions, display='list',
   const fetchCopy = () => elementActions.fetchElement('catalogs', catalog.id, 'copy')
   const fetchNested = () => elementActions.fetchElement('catalogs', catalog.id, 'nested')
 
-  const toggleAvailable = () => elementActions.storeElement('catalogs', {...catalog, available: !catalog.available }, null, false)
-  const toggleLocked = () => elementActions.storeElement('catalogs', {...catalog, locked: !catalog.locked }, null, false)
+  const toggleAvailable = () => elementActions.storeElement('catalogs', {...catalog, available: !catalog.available })
+  const toggleLocked = () => elementActions.storeElement('catalogs', {...catalog, locked: !catalog.locked })
 
-  const toggleCurrentSite = () => elementActions.storeElement('catalogs', catalog, 'toggle-site', false)
+  const toggleCurrentSite = () => elementActions.storeElement('catalogs', catalog, 'toggle-site')
 
   const createSection = () => elementActions.createElement('sections', { catalog })
 

diff --git a/rdmo/management/assets/js/components/element/Task.js b/rdmo/management/assets/js/components/element/Task.js
@@ -19,9 +19,9 @@ const Task = ({ config, task, elementActions, filter=false, filterSites=false, f
 
   const fetchEdit = () => elementActions.fetchElement('tasks', task.id)
   const fetchCopy = () => elementActions.fetchElement('tasks', task.id, 'copy')
-  const toggleAvailable = () => elementActions.storeElement('tasks', {...task, available: !task.available }, null, false)
-  const toggleLocked = () => elementActions.storeElement('tasks', {...task, locked: !task.locked }, null, false)
-  const toggleCurrentSite = () => elementActions.storeElement('tasks', task, 'toggle-site', false)
+  const toggleAvailable = () => elementActions.storeElement('tasks', {...task, available: !task.available })
+  const toggleLocked = () => elementActions.storeElement('tasks', {...task, locked: !task.locked })
+  const toggleCurrentSite = () => elementActions.storeElement('tasks', task, 'toggle-site')
 
   const fetchCondition = (index) => elementActions.fetchElement('conditions', task.conditions[index])
 

diff --git a/rdmo/management/assets/js/components/element/View.js b/rdmo/management/assets/js/components/element/View.js
@@ -18,9 +18,9 @@ const View = ({ config, view, elementActions, filter=false, filterSites=false, f
 
   const fetchEdit = () => elementActions.fetchElement('views', view.id)
   const fetchCopy = () => elementActions.fetchElement('views', view.id, 'copy')
-  const toggleAvailable = () => elementActions.storeElement('views', {...view, available: !view.available }, null, false)
-  const toggleLocked = () => elementActions.storeElement('views', {...view, locked: !view.locked }, null, false)
-  const toggleCurrentSite = () => elementActions.storeElement('views', view, 'toggle-site', false)
+  const toggleAvailable = () => elementActions.storeElement('views', {...view, available: !view.available })
+  const toggleLocked = () => elementActions.storeElement('views', {...view, locked: !view.locked })
+  const toggleCurrentSite = () => elementActions.storeElement('views', view, 'toggle-site')
 
   return showElement && (
     <li className="list-group-item">