Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console final report enhancement #476

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Petrarka0
Copy link

@Petrarka0 Petrarka0 commented Mar 22, 2024

Settings.logger.less now affect final report
Streamer.print_history() tweak for more readability and parse.

before if Settings.logger.less = True:

--- alot of annoing bet information ---
dd/mm hh:mm:ss - 馃 Streamer(username=streamer, channel_id=12345678, channel_points=112.06k), Total Points Gained (after farming - before farming): 70
dd/mm hh:mm:ss - 馃挵 CLAIM (1 times, 50 gained), WATCH (2 times, 20 gained)

after:

dd/mm hh:mm:ss - 馃挵 streamer (112.06k points), Total Points Gained: 70
CLAIM (1 times, 50 gained)
WATCH (2 times, 20 gained)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on running app

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md)
  • My changes generate no new warnings
  • Any dependent changes have been updated in requirements.txt

@rdavydov rdavydov changed the title Console final report enhantment Console final report enhancement Apr 11, 2024
@rdavydov
Copy link
Owner

@Petrarka0 Not accepted, the program doesn't even start, an obvious bug:

\TwitchChannelPointsMiner\TwitchChannelPointsMiner.py", line 499
    streamer_history = f"\t\t\t{"\n\t\t\t".join(self.streamers[streamer_index].print_history().split("; "))}"
                                  ^
SyntaxError: unexpected character after line continuation character

Please fix it and I'll continue looking into this PR.

@rdavydov rdavydov self-assigned this Apr 11, 2024
@rdavydov rdavydov added the 馃П enhancement New feature or request label Apr 11, 2024
Settings.logger.less now affect final report
Streamer.print_history() tweak for more readability.

before "if Settings.logger.less = True":
--- alot of annoing bet information ---
dd/mm hh:mm:ss - 馃  Streamer(username=streamer, channel_id=12345678, channel_points=112.06k), Total Points Gained (after farming - before farming): 70
dd/mm hh:mm:ss - 馃挵  CLAIM (1 times, 50 gained), WATCH (2 times, 20 gained)

after:
dd/mm hh:mm:ss - 馃挵  streamer (112.06k points), Total Points Gained: 70
                        CLAIM (1 times, 50 gained)
                        WATCH (2 times, 20 gained)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃П enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants