Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #256 #258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix for #256 #258

wants to merge 1 commit into from

Conversation

lava83
Copy link

@lava83 lava83 commented Mar 31, 2016

fix for #256 without use dependency injection in constructor the translator class will initialize when we use it

…anslator class will initialize when we use it
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 25.49% when pulling 3a64831 on lava83:master into 78a4b7d on rcrowe:master.

@barryvdh
Copy link
Collaborator

Are you sure? Isn't the getFunctions method always called?

@lava83
Copy link
Author

lava83 commented Apr 1, 2016

@barryvdh What?

@barryvdh
Copy link
Collaborator

You moved it out the initialisation, but isn't the getFunctions() method still called, even though the extension is not used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants