Merge Twig global scope with Laravel Globals #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the difference between globals an shared? |
astoltz
force-pushed
the
feature/laravel-globals
branch
from
543b59d
to
23ad786
Compare
Shared is the context of the template that is directly being rendered. Global is available to all templates. As an example, Laravel pushes form validation messages to a global called "errors". This is accessible to the main template. However, without this PR, you cannot access "errors" from a macro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you import a template that contains macros, then call one of those macros, they do not have access to the Laravel view globals such as "errors". This patch fixes that.
The code is duplicate of that from Bridge::mergeShared(). The logic in mergeShared might be able to be removed.