Updated patterns to support base64 data urls #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a use case where I'm using the slider in a preview before the user uploads files to the server, so I only have base64 data urls. The loader would just hang because it wouldn't know what to do with them when I tried to navigate to the second image in the list. I simply updated the pattern matching to understand the base64's prefix in addition to the file extensions it already supported.
ghost
mentioned this pull request
|
URLs without extensions also don't work :( |
|
@dankobaia I ran into that as well while developing my site. Fortunately in my case I had full control over my images so I just switched to tacking on a file extension. I couldn't think of a good way to update the slider to support them. If you didn't have control over the images themselves, I wonder if you couldn't trick the slider by adding a query string or a hash to the end of them, so the browser won't actually care but the slider's regex will see it as an image (e.g. https://test.com/image-with-extension?.jpg) |
|
Can anyone merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a use case where I'm using the slider in a preview before the user uploads files to the server, so I only have base64 data urls.
The loader would just hang because it wouldn't know what to do with them when I tried to navigate to the second image in the list.
I simply updated the pattern matching to understand the base64's prefix in addition to the file extensions it already supported.