RavenDB-21679 Require to assign AuthorizationStatus #18506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grisha-kotler
requested changes
May 13, 2024
| AuthenticateConnection = HttpContext.Features.Get<IHttpAuthenticationFeature>() as AuthenticateConnection; | ||
| } | ||
|
|
||
| public AuthorizationStatus GetAuthorizationStatus(string databaseName) |
There was a problem hiding this comment.
Remove this and use it directly via RequestHandler.GetXYZ
src/Raven.Server/Smuggler/Documents/Data/DatabaseSmugglerOptionsServerSide.cs
Show resolved
Hide resolved
src/Raven.Server/Smuggler/Documents/Handlers/SmugglerHandler.cs
Outdated
Show resolved
Hide resolved
src/Raven.Server/Smuggler/Documents/Data/DatabaseSmugglerOptionsServerSide.cs
Outdated
Show resolved
Hide resolved
...n.Server/Documents/Handlers/Processors/Smuggler/AbstractSmugglerHandlerProcessorForImport.cs
Outdated
Show resolved
Hide resolved
efratshenhar
force-pushed
the
RavenDB-21679.fix
branch
2 times, most recently
from
21965dd
to
c2ab941
Compare
grisha-kotler
requested changes
May 16, 2024
...er/Documents/Handlers/Admin/Processors/Indexes/AdminIndexHandlerProcessorForJavaScriptPut.cs
Outdated
Show resolved
Hide resolved
src/Raven.Server/Documents/Handlers/LegacyReplicationHandler.cs
Outdated
Show resolved
Hide resolved
...rver/Documents/Handlers/Processors/SampleData/SampleDataHandlerProcessorForPostSampleData.cs
Outdated
Show resolved
Hide resolved
arekpalinski
approved these changes
May 17, 2024
grisha-kotler
approved these changes
May 19, 2024
ppekrol
approved these changes
May 20, 2024
| protected AbstractDatabaseHandlerProcessor([NotNull] TRequestHandler requestHandler) : base(requestHandler) | ||
| { | ||
| ContextPool = requestHandler.ContextPool; | ||
| Logger = requestHandler.Logger; | ||
| AuthenticateConnection = HttpContext.Features.Get<IHttpAuthenticationFeature>() as AuthenticateConnection; |
There was a problem hiding this comment.
IIRC, this is not free (this is an IEnumerable) and you are now performing that for every single call to the database, even if this is not needed
efratshenhar
force-pushed
the
RavenDB-21679.fix
branch
from
6b6bdb9
to
bc2e447
Compare
|
Please check failing tests - https://jenkins.hibernatingrhinos.com/job/PR_Tests/10867/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RavenDB-21679
Additional description
We encountered a situation where the AuthorizationStatus was not assigned in the DatabaseSmugglerOptionsServerSide class.
Now, we ensure that it's assigned when creating a new instance.
Type of change
How risky is the change?
Backward compatibility
Is it platform specific issue?
Documentation update
Documentation Requiredtag.Testing by Contributor
private)Testing by RavenDB QA team
QA Requiredtag.Is there any existing behavior change of other features due to this change?
UI work
Studio Requiredtag.