RavenDB-21993 - don't allow automatic fail over in changes api when tracking node-specific operations #18494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
It didn't fail in two more test builds: https://jenkins.hibernatingrhinos.com/job/PR_Tests/10798/ so likely not related. |
…racking node-specific operations
arekpalinski
force-pushed
the
RavenDB-21993-6.0
branch
from
838cd2b
to
132d68f
Compare
|
I have rebased the PR just in case to let the tests run again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RavenDB-21993
Additional description
v6.0 PR for #18417
Additional changes:
Disposing the orchestrator (
ShardedDatabaseContext) will dispose existing operations, which in turn will dispose all shards' changes apis.