-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blink gpio10 #350
base: develop
Are you sure you want to change the base?
Blink gpio10 #350
Conversation
This reverts commit 6eb5592.
I'm guessing this PR shouldn't include the JSON file? |
Correct. Sorry, my mistake. What's the best way to correct this? |
As far as I know the existing However, if we were going to include something like this — an additional blink example using an external LED — just like the two "hello world" examples ( In addition, since it's a getting started example, I think it should have a wiring diagram as it requires external wiring, e.g. see https://github.com/raspberrypi/pico-examples/tree/master/i2c/bmp280_i2c where there is a That said, a blink example needs to be the simplest thing possible, parsable by folks that don't even know C, and are just familiar with other languages, and this is far longer and much more complex than the existing blink example. I don't believe this is suitable for folks that'll be looking to a |
That blink example doesn't work on Pico W. There's a separate one for Pico W https://github.com/raspberrypi/pico-examples/blob/master/pico_w/wifi/blink/picow_blink.c |
In the spirit of keeping it simple, someone just starting may purchase the pico w as their first board (I did because I want to do an IOT project).
For those reasons, the current blink example should be updated to be pico w friendly. No problem leaving out the serial coms and the "volatile" declaration for simplicity. |
For the record I fell into this trap getting started, flashing the pico examples on a pico w, scratching my head and flailing about until I realized my mistake. A few more breadcrumbs and safety nets wouldn't hurt the experience. |
Is it going to be any more obvious when you need a led and a resistor to make it work? |
@@ -21,6 +21,7 @@ pico_sdk_init() | |||
include(example_auto_set_url.cmake) | |||
# Add blink example | |||
add_subdirectory(blink) | |||
add_subdirectory(blink-10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blink_external_led
is probably a more useful name than blink-10
?
Propose an additional blink example that