Reinstate "output format" DRM property, and add support on Pi0-3. #6133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a custom property "Output format" that allows the overriding of the default colourspace choice in the way that the old firmware hdmi_pixel_encoding property did. If the chosen format is not supported, then it will still drop back to the older behaviour. This won't be acceptable to upstream, but it adds back the missing functionality of hdmi_pixel_encoding. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Pi4 has had the conversion matrices to drive YCbCr 444 and 422 output for a while, however Pi0-3 hasn't. YCbCr422 can't be supported by the hardware, but YCbCr 444 can be, so add the CCM. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "output format" property had been lost in switching to 6.6, and it appears was never implemented for Pi0-3 (only full/limited range RGB).
I want to double check the CCM for BT601, and ideally ought to add the CCM for BT709, but want the CI build for the reporter on https://forums.raspberrypi.com/viewtopic.php?t=369875