drm: rp1: dpi: Add support for MEDIA_BUS_FMT_RGB565_1X24_CPADHI #6132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new format corresponds to the Raspberry Pi legacy DPI mode 3. Signed-off-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>
|
LGTM
I haven't heard anyone complain that mode 4 is missing from vc4 and rp1 kernel drivers. Selecting RGB666_1X24_CPADHI and amending the pinctrl is the way to do it, but it's not high on my priority list. |
|
A quick test using VGA666 board, |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
May 3, 2024
kernel: DSI0 colour swap fixes See: raspberrypi/linux#6094 kernel: overlays: Add overlay for the Pineboards Hat Ai! See: raspberrypi/linux#6126 kernel: drm: rp1: dpi: Add support for MEDIA_BUS_FMT_RGB565_1X24_CPADHI See: raspberrypi/linux#6132
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
May 3, 2024
kernel: DSI0 colour swap fixes See: raspberrypi/linux#6094 kernel: overlays: Add overlay for the Pineboards Hat Ai! See: raspberrypi/linux#6126 kernel: drm: rp1: dpi: Add support for MEDIA_BUS_FMT_RGB565_1X24_CPADHI See: raspberrypi/linux#6132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new format corresponds to the Raspberry Pi legacy DPI mode 3. This should enable it to work on Raspberry Pi 5.
I suppose I should test it before merging!
XXX we still don't have a way to get DPI mode 4. RGB666_1X24_CPADHI will put the bits in the right places, a named pinctrl is defined for Raspberry Pi 5 / RP1, but no pinctrl is defined for earlier Raspberry Pi models.