Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver code for DFRobot's 8.8-inch DSI interface touch screen. #6058

Open
wants to merge 8 commits into
base: rpi-6.6.y
Choose a base branch
from

Conversation

fary99
Copy link

@fary99 fary99 commented Mar 22, 2024

No description provided.

@6by9
Copy link
Contributor

6by9 commented Mar 25, 2024

Thanks for the patches, but a few things to sort.

  • Kernel coding style mandates tabs (set to 8-spaces) rather than spaces for indentation. The checkpatch.pl script (in the scripts directory) allows quick checking for obvious coding style errors. Currently panel-dfrobot-dsi.c produces "43 errors, 194 warnings, 3 checks, 278 lines checked".
  • Adding a driver should be one patch that includes the driver C file, Kconfig, and Makefile changes. Ideally MAINTAINERS should also be updated if the driver too.
  • Adding an overlay should be one patch that includes the dtbo file, Makefile change, and documentation in README.
  • What is the need for a new dfrobot_gt911 driver when drivers/input/touchscreen/goodix.c already supports GT911? It's already used by the HyperPixel4 and Waveshare panel overlays.
  • Why is your overlay enabling i2c_arm, when your panel and touch controller are both connected to i2c_csi_dsi?
  • Have you considered adding a dsi0 override for use on Pi5?
  • Why do df_panel_enable and df_panel_disable set register 0x01, which is also set by df_panel_bl_update_status as the backlight intensity? You have assigned the backlight to the panel, so that should be handled automatically, and then be enabled at the currently configured brightness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants