Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input: goodix: Support output-only reset lines #5777

Draft
wants to merge 1 commit into
base: rpi-6.1.y
Choose a base branch
from

Conversation

pelwell
Copy link
Contributor

@pelwell pelwell commented Dec 8, 2023

Although the motivation behind initialising the reset GPIO as an input is sound, it prevents the driver from being used with an output-only GPIO controller. Fall back to trying to create it as an output.

See: https://forums.raspberrypi.com/viewtopic.php?t=361103

@pelwell pelwell marked this pull request as draft December 8, 2023 12:17
@pelwell
Copy link
Contributor Author

pelwell commented Dec 8, 2023

@Gadgetoid Does this help? Wait about 45 minutes for the builds to complete then run sudo rpi-update pulls/5777 to install a trial build.

@Gadgetoid
Copy link
Contributor

Build failed with:

../drivers/input/touchscreen/goodix.c: In function ‘goodix_get_gpio_config’:
../drivers/input/touchscreen/goodix.c:1064:76: error: ‘GPIOD_OUT’ undeclared (first use in this function); did you mean ‘GPIOD_IN’?
 1064 |                 gpiod = devm_gpiod_get_optional(dev, GOODIX_GPIO_RST_NAME, GPIOD_OUT);
      |                                                                            ^~~~~~~~~
      |                                                                            GPIOD_IN
../drivers/input/touchscreen/goodix.c:1064:76: note: each undeclared identifier is reported only once for each function it appears in

Although the motivation behind initialising the reset GPIO as an input
is sound, it prevents the driver from being used with an output-only
GPIO controller. Fall back to trying to create it as an output.

See: https://forums.raspberrypi.com/viewtopic.php?t=361103

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@pelwell
Copy link
Contributor Author

pelwell commented Dec 8, 2023

It should be good now - wait about half an hour for the build.

@pelwell
Copy link
Contributor Author

pelwell commented Dec 8, 2023

Once you've confirmed this works I'll update the branch, remove the draft status and merge. There's no rush, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants