Update graphics-utilities.adoc #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR in userland repo - man page update - raspberrypi/userland#703 |
ghost
mentioned this pull request
lurch
reviewed
Aug 23, 2021
| @@ -138,7 +138,7 @@ Returns the throttled state of the system. This is a bit pattern - a bit being s | |||
|
|
|||
| ==== measure_temp | |||
|
|
|||
| Returns the temperature of the SoC as measured by the on-board temperature sensor. | |||
| Returns the temperature of the SoC as measured by its internal temperature sensor. On Raspberry Pi 4 the `pmic` subcommand can be used to instead return the temperature of the PMIC. | |||
There was a problem hiding this comment.
It's not entirely clear if this means vcgencmd pmic or vcgencmd measure_temp pmic?
Also, I may just be reading it wrong but the "instead" implies that the former option isn't available and only the latter option is available? Maybe it's worth rewording to use "also" to clarify that both options are available, IYSWIM?
There was a problem hiding this comment.
I've changed the wording slightly.
(A quick test on a Pi 3B+ and Pi 1 reveals that on pre-Pi4 boards, vcgencmd measure_temp pmic will silently ignore the pmic parameter and just return the temperature of the SoC).
|
Ready to merge? |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document
pmicsubcommand tovcgencmd measure_temp