Simplify cuml array #5166
Open
Simplify cuml array #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphicks
approved these changes
Jan 27, 2023
csadorf
reviewed
Jan 31, 2023
ajschmidt8
force-pushed
the
branch-23.04
branch
from
6f2fda7
to
20d2690
Compare
Remove unreachable code. Both RMM DeviceBuffers and cuDF Buffers advertise a `__cuda_array_interface__` property, so it is impossible to fall through to the `AttributeError` block in those cases.
We should assign, not check for equality.
wence-
force-pushed
the
wence/simplify-cuml-array
branch
from
c004c68
to
4ff462f
Compare
|
I rebased onto trunk to drop all the merge-conflicted (?) changes. I think this is OK for a review (ops-codeowners, cmake-codeowners and cpp-codeowners I think are now unnecessary reviewing groups). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while reviewing #5154.
Plus an extra (probably benign) typo-bug while I'm here.
cc @wphicks