Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor API context managers #5142

Draft
wants to merge 49 commits into
base: branch-23.04
Choose a base branch
from

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Jan 20, 2023

No description provided.

@csadorf csadorf added the Tech Debt Issues related to debt label Jan 20, 2023
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 20, 2023
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change breaking Breaking change and removed non-breaking Non-breaking change labels Jan 20, 2023
@csadorf
Copy link
Contributor Author

csadorf commented Jan 20, 2023

This change is intended to not be breaking, but I have labeled it as breaking until we have checked that it is not.

@csadorf csadorf force-pushed the fea-refactor-api-context-managers branch 5 times, most recently from b18dd90 to 7ecabc8 Compare January 31, 2023 09:32
@csadorf csadorf changed the base branch from branch-23.02 to branch-23.04 January 31, 2023 09:32
@csadorf csadorf force-pushed the fea-refactor-api-context-managers branch from 7ecabc8 to c171cae Compare January 31, 2023 12:16
@csadorf csadorf changed the base branch from branch-23.04 to branch-23.02 January 31, 2023 12:16
@csadorf csadorf force-pushed the fea-refactor-api-context-managers branch 2 times, most recently from 0c860b7 to f8a3106 Compare February 6, 2023 08:15
@codecov-commenter
Copy link

Codecov Report

Base: 67.17% // Head: 66.75% // Decreases project coverage by -0.42% ⚠️

Coverage data is based on head (f8a3106) compared to base (8abfd64).
Patch coverage: 98.09% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #5142      +/-   ##
================================================
- Coverage         67.17%   66.75%   -0.42%     
================================================
  Files               192      191       -1     
  Lines             12425    12235     -190     
================================================
- Hits               8346     8167     -179     
+ Misses             4079     4068      -11     
Impacted Files Coverage Δ
python/cuml/internals/base_helpers.py 80.59% <ø> (ø)
python/cuml/internals/api_decorators.py 97.82% <97.84%> (+0.23%) ⬆️
...party/sklearn/preprocessing/_column_transformer.py 72.99% <100.00%> (ø)
python/cuml/common/array_descriptor.py 100.00% <100.00%> (ø)
python/cuml/internals/__init__.py 100.00% <100.00%> (ø)
python/cuml/internals/global_settings.py 78.78% <100.00%> (+2.12%) ⬆️
python/cuml/multiclass/multiclass.py 84.61% <100.00%> (ø)
python/cuml/internals/array_sparse.py 84.26% <0.00%> (-1.13%) ⬇️
python/cuml/internals/array.py 81.02% <0.00%> (-0.60%) ⬇️
python/cuml/internals/input_utils.py 77.88% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@csadorf csadorf force-pushed the fea-refactor-api-context-managers branch 2 times, most recently from a8677ef to 9089f17 Compare February 8, 2023 13:16
@github-actions github-actions bot added CMake conda conda issue labels Feb 8, 2023
@csadorf csadorf force-pushed the fea-refactor-api-context-managers branch from a1b804d to b5fc198 Compare February 14, 2023 12:18
@ajschmidt8 ajschmidt8 removed the request for review from a team February 14, 2023 13:26
@csadorf csadorf marked this pull request as draft February 17, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function Tech Debt Issues related to debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants