Implement upstream changes from scikit-image 0.23 (part 2 of 2: morphology) #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grlee77
added
improvement
also attempt broadcast_to of provided alpha value
use __init__.pyi
* replace remove_kwarg and deprecate_kwarg with deprecate_parameter * rename gaussian parameter output->out
* add new intensity_std property * fix bug in cache
* now warns if any image contained zero intensity everywhere
* add mode argument to control edge handling behavior * pad any even length dimensions to odd to fix opening and closing behavior in even cases
* also adds boundary mode support for grayscale morphology functions
grlee77
force-pushed
the
skimage023_morphology_updates
branch
from
5bc3ed1
to
728f2af
Compare
* need check based on CuPy, not SciPy
store list in sorted order to avoid error like: Different tests were collected between gw1 and gw5
|
/merge |
AyodeAwe
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of non-trivial changes to the morphology module, so I broke those out from the other changes in #727. Please review and merge that MR first before reviewing this one.
Highlights from upstream are:
modeargument that controls how values outside the image boundaries are interpretedmodeandcvalarguments that control how boundaries are extended (these were already available inscipy.ndimage/cupyx.scipy.ndimage, they just weren't exposed via theskimage/cuCIMAPIs)Aside from the upstream changes, novel changes in this MR are:
pytest.mark.parametrizeskimageCPU outputs instead fetching previously saved valuesI marked as "non-breaking" as the existing behavior has not changed except in the case of the bug fixes for even-sized footprints.