Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash when setting 'max_console_history-size=None' in rc.conf #2972

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meluchoMZ
Copy link

ISSUE TYPE

  • Bug fix

RUNTIME ENVIRONMENT

  • Operating system and version: Arch kernel 6.8.8-arch1-1
  • Terminal emulator and version: konsole 24.02.2
  • Python version: 3.12.3
  • Ranger version/commit: 38bb890
  • Locale: es_ES.UTF-8

CHECKLIST

  • The CONTRIBUTING document has been read [REQUIRED]
  • All changes follow the code style [REQUIRED]
  • All new and existing tests pass [REQUIRED]
  • Changes require config files to be updated
    • Config files have been updated
  • Changes require documentation to be updated
    • Documentation has been updated
  • Changes require tests to be updated
    • Tests have been updated

DESCRIPTION

Allow for maxlen to be None and avoid operating with it in numeric computations. The code of History.add and History.rebase has been adapted in order to take this change into account. History behaves as expected when maxlen=None

  • on add operations, the history has no limit
  • on rebase operations, the history is rebased successfully

MOTIVATION AND CONTEXT

The changes solve this issue #1895

TESTING

All of the tests of ranger/test were executed and passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant