Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import other configs from rifle.conf #2957

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

therealolie
Copy link

@therealolie therealolie commented Mar 10, 2024

ISSUE TYPE

  • Improvement/feature implementation

RUNTIME ENVIRONMENT

  • Operating system and version: Arch linux rolling
  • Terminal emulator and version: kitty 0.31.0
  • Python version: 3.11.8$
  • Ranger version/commit:
  • Locale:

CHECKLIST

  • The CONTRIBUTING document has been read [REQUIRED]
  • All changes follow the code style [REQUIRED]
  • All new and existing tests pass [REQUIRED] (i got permission trough irc to ignore this)
  • Changes require config files to be updated
    • Config files have been updated
  • Changes require documentation to be updated
    • Documentation has been updated
  • Changes require tests to be updated
    • Tests have been updated

DESCRIPTION

you can add !import /path/to/file to rifle.conf to import another configuration file
works the same as if you copied the contents of the file and paated them into the config

MOTIVATION AND CONTEXT

you can break up your config for readability n stuff

currently, keeping configs up to date was your responsibility
now you can just import the original config at the bottom of yours to be up to date

TESTING

didnt run any tests, make test crashes
from irc:

monty 22:02:43
Feel free to ignore the pylint stuff until I've been able to deal with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant