Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download returns #303

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

yarimiz
Copy link
Contributor

@yarimiz yarimiz commented Sep 6, 2023

This PR is for fixing 3 issues in the utils.download_returns method:

  1. There's no need for progress bar when downloading only 1 ticker
  2. There's no need for multithreading when downloading only one ticker. This actually caused issue when running inside Flask
  3. Rename the downloaded returns to the ticker's name instead of "Close". This affects the tearsheet.

@grzesir
Copy link

grzesir commented Jan 31, 2024

Since this library no longer seems to be maintained, we have created a duplicate of it that we plan to maintain and improve over time. If you'd like to use our version check it out here: https://github.com/Lumiwealth/quantstats_lumi

Please feel free to fork and send your pull request to this new library, we will be actively monitoring the library and approving PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants