New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename innerJoin to intersectionWith #3225
base: master
Are you sure you want to change the base?
chore: rename innerJoin to intersectionWith #3225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Of course that's a breaking change ;) Question: did you rename the test file?
@customcommander , Yes, thanks for remind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and makes perfect sense. Would like another approval just in case. Otherwise let's merge this end of week latest?
@CrossEye Any objection? |
I agree with the change. I guess ,,we need to decide whether |
@CrossEye: I wouldn't bother with |
innerJoin
is a sql command,R.innerJoin
only hasinner
but nojoin
, so rename it tointersectionWith
may be more accurate?