Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename innerJoin to intersectionWith #3225

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adispring
Copy link
Member

innerJoin is a sql command, R.innerJoin only has inner but no join, so rename it to intersectionWith may be more accurate?

Copy link
Member

@customcommander customcommander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Of course that's a breaking change ;) Question: did you rename the test file?

@adispring
Copy link
Member Author

@customcommander , Yes, thanks for remind.

Copy link
Member

@customcommander customcommander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes perfect sense. Would like another approval just in case. Otherwise let's merge this end of week latest?

@customcommander
Copy link
Member

@CrossEye Any objection?

@CrossEye
Copy link
Member

CrossEye commented Feb 5, 2022

I agree with the change.

I guess ,,we need to decide whether 1.0 or 0.29 is next. When we rename a function, we usually keep the old name around as an alias for a minor version. If we're building 0.29 I would do so, but I think if we're headed right for 1.0, then we need to skip it this time.

@customcommander
Copy link
Member

@CrossEye: I wouldn't bother with 0.29 at this point and would rather keep the momentum for 1.0.0 and ship as many breaking changes in that one.

@Retro64 Retro64 mentioned this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants