Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make R.eqProps safe for null/undefined arguments #2943

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make R.eqProps safe for null/undefined arguments #2943

wants to merge 1 commit into from

Conversation

adispring
Copy link
Member

No description provided.

@CrossEye
Copy link
Member

This looks great to me. I see no downside.

Any one else, @ramda/core?

Bradcomp
Bradcomp approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@Bradcomp Bradcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:bowtie:

I think this is positive. Any counter examples I can think of seem to either be handled or else not effect the correctness of the function.

@CrossEye CrossEye added the resolve-conflicts PR needs to be updated due to conflicts before merging label Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bradcomp Bradcomp Bradcomp approved these changes

Assignees
No one assigned
Labels
resolve-conflicts PR needs to be updated due to conflicts before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adispring @CrossEye @Bradcomp