Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement uniqBy in terms of filter #2641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement uniqBy in terms of filter #2641

wants to merge 1 commit into from

Conversation

wojpawlik
Copy link
Contributor

No description provided.

CrossEye
CrossEye previously approved these changes Jan 23, 2022
View reviewed changes
@CrossEye
Copy link
Member

This PR was entirely overlooked. I'm not sure why; likely no one was looking at issues at all at the time and by the time they were, this had fallen through the cracks. Sorry about that.

This makes sense to me. @wojpawlik: if you're still interested, would you be willing to rebase the changes against HEAD?

If not, someone else will likely get to this soon.

@customcommander
Copy link
Member

If not, someone else will likely get to this soon.

I was going to but the author hasn't allowed maintainers write access to the repo

@CrossEye CrossEye added the resolve-conflicts PR needs to be updated due to conflicts before merging label Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrossEye CrossEye CrossEye left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
resolve-conflicts PR needs to be updated due to conflicts before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wojpawlik @CrossEye @customcommander