Refactor: Modularization #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we follow here the existing packages structure, may be we can also split: - data module to have data, local & remote modules - ui module to have ui & presentation modules to improve SOLID principle
julienherrero
force-pushed
the
feature-modularization
branch
from
d31125e
to
05298ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Modularize this sample to separate layers and enforce its responsibilities.
Impacts: Not even so big, it just create some
build.gradlefiles (maybe we can optimize some dependencies declaration by the way) and update imports in each modules.Note:
appmodule is just here to allow dagger to do its work into all modules.This branch can also be not merged in master but duplicated in guardian-demo to present this modularized alternative.
Do not hesitate to discuss this PR with me !
(see #5)