Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string keys in example for Deserialization #2385

Open
wants to merge 2 commits into
base: 0-10-stable
Choose a base branch
from

Conversation

wasabigeek
Copy link

fixes #2384

@wasifhossain
Copy link
Member

great! could you also include the following changes:

@@ -59,6 +59,7 @@ module ActiveModelSerializers
         #     # {
         #     #   title: 'Title 1',
         #     #   date: '2015-12-20',
+        #     #   id: 1,
         #     #   author_id: 2,
         #     #   second_author_id: nil
         #     #   comment_ids: [3, 4]

on line 62, and

@@ -70,8 +71,8 @@ module ActiveModelSerializers
         #     # {
         #     #   title: 'Title 1',
         #     #   published_at: '2015-12-20',
-        #     #   author_id: '2',
-        #     #   author_type: 'people'
+        #     #   author_id: 2,
+        #     #   author_type: 'User'
         #     # }
         #
         def parse!(document, options = {})

on lines 73/74

@wasabigeek
Copy link
Author

Done! Noob question, how did you paste the diffs? And should I be worried about the Appveyor failures?

@wasifhossain
Copy link
Member

how did you paste the diffs?

opening 3 backticks are followed by diff :)

And should I be worried about the Appveyor failures?

NO for any of the current failures (travis/appveyor), as we still have some other CI issues to resolve

@wasabigeek
Copy link
Author

wasabigeek commented Jun 30, 2020

Fancy, didn’t know the diff coloration came built in. Ok great, let me know if there’s anything else i should change here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants