[RFC][WIP] Resource Routing #1476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dgeb |
| The JSON API resource routing declaration would be: | ||
|
|
||
| ```ruby | ||
| contraint mime_type: :json_api do |
There was a problem hiding this comment.
constraint is for the wrong keyword here. What I want is more of a concern that extends resources.
|
Related: #834 |
| @@ -0,0 +1,111 @@ | |||
| - Start Date: (2016-01-28) | |||
| - RFC PR: https://github.com/rails-api/active_model_serializers/pull/dddd | |||
| - ActiveModelSerializers Issue: https://github.com/rails-api/active_model_serializers/issues/dddd | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per: #1236
The content in this PR is a bookmark I intend to expand, submitted early as a
work in progress (WIP) for surfacing the concern.
Since the JSON API spec includes resource routing concerns, we should consider
how we want to handle that in AMS.
For this first starting point, I basically copied the results of the hard work
of the JSONAPI::Resources team and their
demo app.