Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vue-input-otp #393

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

feat: vue-input-otp #393

wants to merge 4 commits into from

Conversation

sadeghbarati
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Mar 7, 2024

Deploying with Cloudflare Pages

Name Result
Last commit: 4d78e5d9
Status: ⚡️ Deployment in progress...
Preview URL: https://9f98d524.shadcn-vue.pages.dev
Branch Preview URL: https://9f98d524.shadcn-vue.pages.dev

@zernonia
Copy link
Contributor

zernonia commented Mar 8, 2024

Why vue-input-otp, does the one from radix-vue not fitting? 🤔

it's basically the same as PinInput

Futhermore, adding more external packages always worries me with the integration with styling and js transformation.

@zernonia
Copy link
Contributor

zernonia commented Mar 8, 2024

noticed a bug yaa.. seems like clicking on other input doesn't focus on them.. need to click multiple time then only able to focus other.

Screen.Recording.2024-03-08.at.2.44.40.PM.mov

@sadeghbarati
Copy link
Collaborator Author

@wobsoriano
Copy link

wobsoriano commented Mar 8, 2024

Hey, I'm excited for this! Just a heads up - I saw a branch in the original repo and I think he's about to add in support for Svelte and Vue so I think the vue-input-otp package will likely be deprecated in favor of that soon.

https://github.com/guilhermerodz/input-otp/tree/feat/multi-frameworks/lib

cc @guilhermerodz

@guilhermerodz
Copy link

guilhermerodz commented Mar 11, 2024

hey @wobsoriano a vuejs + svelte version is on input-otp roadmap.

I'll wait for the react lib to become stable (no significant issues opened in ~10-15 days) and then finally start working in the vanilla JS core so that we can export to another libraries such as vuejs and svelte. how does that sound?

@wobsoriano
Copy link

@guilhermerodz that sounds like a plan! For the meantime, I'll keep the vue-input-otp package in sync with the React version until your Svelte and Vue versions are released :) Once they're ready, I'll gladly include a link to your repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants