Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No multiple parents #1279

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

No multiple parents #1279

wants to merge 3 commits into from

Conversation

emmanuelmathot
Copy link
Collaborator

Related Issue(s): #1230, #1236, #1273

Proposed Changes:

  1. Clarify unique parent link requirement
  2. Added collection relation type for link in catalog and collection

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@emmanuelmathot emmanuelmathot changed the title Nomultiparents No multiple parents May 7, 2024
@m-mohr
Copy link
Collaborator

m-mohr commented May 7, 2024

I think we only really discussed parent links so far, i.e. #1230.

I don't think this necessarily should solve #1236 and #1273. At least I'd like to discuss it first.

@@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- The `keywords` field known from Collections is available in common metadata. ([#1187](https://github.com/radiantearth/stac-spec/issues/1187))
- The `license` field additionally supports SPDX expressions and the value `other`.
- The `roles` field known from Assets and Providers is available in common metadata. ([#1267](https://github.com/radiantearth/stac-spec/issues/1267))
- `collection` relationship type for link in catalog and collection
- Clarification on unique parent link requirement
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be moved to Changed or Fixed, I think.

@@ -657,6 +657,13 @@ So if you are writing a STAC client it is recommended to start with just support
turn, if your data is published online publicly or for use on an intranet then following these recommendations will ensure
that a wider range of clients will work with it.

#### Unique Parent Link

STAC catalogs do not support multiple parents. Links with `rel` of type `parent` and `collection` must be unique.
Copy link
Collaborator

@m-mohr m-mohr May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The following sounds like a requirement but is in best practices. Should this be moved to the spec?

    STAC catalogs do not support multiple parents.

  2. There can be multiple parent links for different encodings (e.g. application/json and text/html). We should clarify that this only applies for STAC-specific media types.
  3. This may need a discussion about collections first. I'm a bit hesistant here, because OGC looks into supporting multiple collections, I think.
    On the other hand, we should also clarify that root should be unique.

Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@emmanuelmathot
Copy link
Collaborator Author

This PR is set at the agenda of the next STAC meetup along with the collections discussions.

@emmanuelmathot emmanuelmathot added this to the 1.1 milestone May 14, 2024
@m-mohr m-mohr linked an issue May 14, 2024 that may be closed by this pull request
@emmanuelmathot
Copy link
Collaborator Author

emmanuelmathot commented Jun 3, 2024

Discussed in STAC meetup:

  • Single STAC parent and root in spec
  • Different encodings with same relation type
  • Leave collection out of PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple parents?
2 participants