Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Partial Order design proposal #276

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

Add Partial Order design proposal #276

wants to merge 25 commits into from

Commits on Feb 8, 2023

  1. Add Partial Order design proposal

    @AlexKnauth
    AlexKnauth committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    7fa0243 View commit details
    Browse the repository at this point in the history

  2. Start PartialOrder implementation

    @AlexKnauth
    AlexKnauth committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    52bea25 View commit details
    Browse the repository at this point in the history

  3. Self is implicit

    @AlexKnauth
    AlexKnauth committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    2c3b0e6 View commit details
    Browse the repository at this point in the history

  4. Add within to design

    @AlexKnauth
    AlexKnauth committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    2d20e6b View commit details
    Browse the repository at this point in the history

  5. Implement within

    @AlexKnauth
    AlexKnauth committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    f8af877 View commit details
    Browse the repository at this point in the history

  6. Add Lexicographic class 

    normal lists still use a product order, only Lexicographic lists use lexicographic order
    @AlexKnauth
    AlexKnauth committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    a8d84be View commit details
    Browse the repository at this point in the history

  7. Add Lexicographic.and macro

    @AlexKnauth
    AlexKnauth committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    4fae130 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Pass the pieces in the same order they came in

    @AlexKnauth
    AlexKnauth committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    f55fc81 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Factor out partial-order-util 

    Implementations of other design-options will use some of the same datatypes and operations
    @AlexKnauth
    AlexKnauth committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    beacd59 View commit details
    Browse the repository at this point in the history

  2. Add Option D: false on incomparable

    @AlexKnauth
    AlexKnauth committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    b5a28a3 View commit details
    Browse the repository at this point in the history

  3. Factor out product-compare/recur

    @AlexKnauth
    AlexKnauth committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    a07c911 View commit details
    Browse the repository at this point in the history

  4. Start PartialOrder option D-A implementation

    @AlexKnauth
    AlexKnauth committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    dd3272c View commit details
    Browse the repository at this point in the history

  5. Check eq? in product-compare/recur 

    Don't check eq? before that because cases like NaN can refuse to be equal to themselves.
    @AlexKnauth
    AlexKnauth committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    7254627 View commit details
    Browse the repository at this point in the history

  6. Test that it doesn't check eq? too soon

    @AlexKnauth
    AlexKnauth committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    80783e5 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. Use #nan literal

    @AlexKnauth
    AlexKnauth committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    3f31229 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Start PartialOrder option D-C implementation 

    depends on racket partial-order branch:
https://github.com/AlexKnauth/racket/tree/partial-order

TODO: test compare_hash_code
    @AlexKnauth
    AlexKnauth committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    5a4c2e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. D-C: Add flvector test

    @AlexKnauth
    AlexKnauth committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    01d0789 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. More flvector tests

    @AlexKnauth
    AlexKnauth committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    e909370 View commit details
    Browse the repository at this point in the history

  2. D-C: Connect an Equatable to PartialOrder

    @AlexKnauth
    AlexKnauth committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    4c735d7 View commit details
    Browse the repository at this point in the history

  3. Add separate D-A and D-C files

    @AlexKnauth
    AlexKnauth committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    c5a3885 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. D-C: Add partial_order default via key

    @AlexKnauth
    AlexKnauth committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    9286812 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. D-C: Use equal-hash-code/recur 

    no need to have prop:partial-order built in to Racket if equal-hash-code/recur is built in instead
    @AlexKnauth
    AlexKnauth committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    8515b78 View commit details
    Browse the repository at this point in the history

  2. Refactor into partial-order-util

    @AlexKnauth
    AlexKnauth committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    56db933 View commit details
    Browse the repository at this point in the history

  3. Add mode to product-compare/recur

    @AlexKnauth
    AlexKnauth committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    1a41023 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Start option E implementation

    @AlexKnauth
    AlexKnauth committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    7b9fe2d View commit details
    Browse the repository at this point in the history