New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier to find information about the logging levels in logging.md #1852
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,6 +77,8 @@ if the environment variable is set, the configuration key `log.file` will not ha | |
RabbitMQ starts logging early on node start. See the [Configuration guide](./configure) | ||
for a general overview of how to configure RabbitMQ. | ||
|
||
The full list of available configuration options can be found in the [example rabbitmq.conf -file](https://github.com/rabbitmq/rabbitmq-server/blob/v3.13.x/deps/rabbit/docs/rabbitmq.conf.example). | ||
|
||
### Logging to a File {#logging-to-a-file} | ||
|
||
Logging to a file is one of the most common options for RabbitMQ installations. In modern releases, | ||
|
@@ -107,7 +109,7 @@ The following example instructs RabbitMQ to log to a file at the `debug` level: | |
log.file.level = debug | ||
``` | ||
|
||
Supported log levels ca be found in the [example rabbitmq.conf file](https://github.com/rabbitmq/rabbitmq-server/blob/v3.13.x/deps/rabbit/docs/rabbitmq.conf.example). | ||
> Supported log levels are discussed in the [Log Levels -section](#log-levels) found below. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Likewise, could you please remove the "-" before "section"? |
||
|
||
Logging to a file can be deactivated with | ||
|
||
|
@@ -217,7 +219,7 @@ The following example instructs RabbitMQ to use the `debug` logging level when l | |
log.console.level = debug | ||
``` | ||
|
||
Supported log levels ca be found in the [example rabbitmq.conf file](https://github.com/rabbitmq/rabbitmq-server/blob/v3.13.x/deps/rabbit/docs/rabbitmq.conf.example). | ||
> Supported log levels are discussed in the [Log Levels -section](#log-levels) found below. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Likewise, could you please remove the "-" before "section"? |
||
|
||
Logging to console in JSON format: | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove the "-" before "file"? Our Doc writer is unavailable right now to confirm but we don't use this anywhere in the docs AFAIK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to mention that it is a file, it should be obvious to the reader.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why we need to link to this example file from this guide, given that we already link to the configuration guide.