rabbit_peer_discovery: Pass inetrc config file to temporary hidden node (backport #10904) #11086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
… "DB ready" state [Why] When peer discovery runs on initial boot, the database layer is not ready when peer discovery is executed. Thus if the node selects itself as the node to "join", it shouldn't pay attention to the database readyness otherwise it would wait forever. (cherry picked from commit 54f5ab5)
[Why] As shown in #10728, in an IPv6-only environment, `kernel` name resolution must be configured through an inetrc file. The temporary hidden node must be configured exactly like the main node (and all nodes in the cluster in fact) to allow communication. Thus we must pass the same inetrc file to that temporary hidden node. This wasn’t the case before this patch. [How] We query the main node’s kernel to see if there is any inetrc file set and we use the same on the temporary hidden node’s command line. While here, extract the handling of the `proto_dist` module from the TLS code. This parameter may be used outside of TLS like this IPv6-only environment. V2: Accept `inetrc` filenames as atoms, not only lists. `kernel` seems to accept them. This makes a better user experience for users used to Bourne shell quoting not knowing that single quotes have a special meaning in Erlang. Fixes #10728. (cherry picked from commit 8425afa)
…idden node [Why] We want to make sure that the queried remote node doesn't know about the querying node. That's why we use a temporary hidden node in the first place. In fact, it is possible to start the temporary hidden node and communicate with it using an alternative connection instead of the regular Erlang distribution. This further ensures that the two RabbitMQ nodes don't connect to each other while properties are queried. [How] We use the `standard_io` alternative connection. We need to use `peer:call/4` instead of `erpc:call/4` to run code on the temporary hidden node. While here, we add assertions to verify that the three node didn't form a full mesh network at the end of the query code. (cherry picked from commit 27b9027)
(cherry picked from commit bd2d85f)
… hidden node ... used by peer discovery. (cherry picked from commit dbf9dfb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As shown in #10728, in an IPv6-only environment,
kernelname resolution must be configured through an inetrc file.The temporary hidden node must be configured exactly like the main node (and all nodes in the cluster in fact) to allow communication. Thus we must pass the same inetrc file to that temporary hidden node. This wasn’t the case before this patch.
How
We query the main node’s kernel to see if there is any inetrc file set and we use the same on the temporary hidden node’s command line.
While here, extract the handling of the
proto_distmodule from the TLS code. This parameter may be used outside of TLS like this IPv6-only environment.V2: Accept
inetrcfilenames as atoms, not only lists.kernelseems to accept them. This makes a better user experience for users used to Bourne shell quoting not knowing that single quotes have a special meaning in Erlang.Note: This is the same pull request as #10759 which was merged and backported when it was still a draft.
References #10840.
Fixes #10728.
This is an automatic backport of pull request #10904 done by Mergify.