PR #10761 follow ups (backport #10825) #10827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The Web MQTT link is not used in the rabbitmq_mqtt Erlang app. This link is only used in the rabbitmq_web_mqtt Erlang app. Hence, move the link to the correct Erlang app. (cherry picked from commit 4b95745)
Fixes #10761 (comment) : "Could you please check a real condition that the old version can't be used as part of this test? is_mixed_versions() will still return true in 10 years when testing RabbitMQ 21.x against 22.x. This function should almost never be used." (cherry picked from commit 3fd96b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of the feedback given in #10761
This is an automatic backport of pull request #10825 done by Mergify.