Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that peer node deals with unicode #10826

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Ensure that peer node deals with unicode #10826

wants to merge 2 commits into from

Commits on Mar 22, 2024

  1. rabbit_peer_discovery: Pass inetrc config file to temporary hidden node 

    [Why]
As shown in #10728, in an IPv6-only environment, `kernel` name
resolution must be configured through an inetrc file.

The temporary hidden node must be configured exactly like the main node
(and all nodes in the cluster in fact) to allow communication. Thus we
must pass the same inetrc file to that temporary hidden node. This
wasn’t the case before this patch.

[How]
We query the main node’s kernel to see if there is any inetrc file set
and we use the same on the temporary hidden node’s command line.

While here, extract the handling of the `proto_dist` module from the TLS
code. This parameter may be used outside of TLS like this IPv6-only
environment.

Fixes #10728.
    @dumbbell @lukebakken
    dumbbell authored and lukebakken committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    3fd96a0 View commit details
    Browse the repository at this point in the history

  2. Ensure that peer node deals with unicode 

    Follow-up to #10759
Related to #10194
Related to erlang/otp#8289
    @lukebakken
    lukebakken committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    d885abe View commit details
    Browse the repository at this point in the history